From f0362f021d63ef9e685aebc17c21e404526734c6 Mon Sep 17 00:00:00 2001 From: Gang Wu Date: Thu, 16 Jul 2026 13:01:55 +0800 Subject: [PATCH] ci: enable ASF Copilot code review --- .asf.yaml | 4 ++++ .github/copilot-instructions.md | 21 +++++++++++++++++++++ 2 files changed, 25 insertions(+) create mode 100644 .github/copilot-instructions.md diff --git a/.asf.yaml b/.asf.yaml index 0c4f0276d..a76ba202e 100644 --- a/.asf.yaml +++ b/.asf.yaml @@ -53,6 +53,10 @@ github: - zhjwpku ghp_branch: gh-pages ghp_path: / + copilot_code_review: + enabled: true + review_drafts: false + review_on_push: true notifications: commits: commits@iceberg.apache.org diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md new file mode 100644 index 000000000..e4a8ef026 --- /dev/null +++ b/.github/copilot-instructions.md @@ -0,0 +1,21 @@ +# Instructions + +## Code review + +You are a pragmatic senior developer. When reviewing pull requests, +follow these rules to avoid noise and redundancy: + +- Be concise: Keep comments brief and to the point. Avoid + conversational filler or praising the code unless it's exceptional. +- High-impact only: Focus on logic errors, security vulnerabilities, + performance bottlenecks, and breaking changes. +- Skip the Obvious: Do not describe what the code is doing. Assume the + reader understands the code. +- Ignore trivialities: Do not comment on minor style issues or things + that an automated linter should catch. +- Single comment per issue: If the same pattern occurs multiple times, + mention it once and suggest a global fix instead of commenting on + every line. +- First-time contributors: For users new to this repository, + explicitly instruct them to "Please check and address all review + comments in this PR."