You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Split out of #442. #207 bumps @ngx-translate/core to v18. That is a major, and today it would touch 317 files. This is the work that makes it touch three.
Drop a dead dependency first.@ngx-translate/http-loader is still in package.json and nothing imports it. #437 replaced it; only a comment at app.config.ts:132 remains.
The boundary exists on paper only. ADR-0003 puts ngx-translate behind the I18N token, but 317 files import @ngx-translate/core directly and only 3 are in core/adapters/. Lint already forbids it; the other 312 sit in eslint-suppressions.json. Note the templates are inline in the .ts files.
Acceptance: http-loader gone, no @ngx-translate/core import outside the adapter, no no-restricted-imports suppressions left for it, and lint, both unit suites and the mocked and mobile Playwright projects green.
Counts measured on main at b1d9280. Background: DOCS/adr/0003-adapter-boundary.md.
Split out of #442. #207 bumps
@ngx-translate/coreto v18. That is a major, and today it would touch 317 files. This is the work that makes it touch three.Drop a dead dependency first.
@ngx-translate/http-loaderis still inpackage.jsonand nothing imports it. #437 replaced it; only a comment atapp.config.ts:132remains.The boundary exists on paper only. ADR-0003 puts ngx-translate behind the
I18Ntoken, but 317 files import@ngx-translate/coredirectly and only 3 are incore/adapters/. Lint already forbids it; the other 312 sit ineslint-suppressions.json. Note the templates are inline in the.tsfiles.Order:
| translateto| appTranslate, droppingTranslateModulefrom each component's imports. 2,860 sites, 604 already done. Not a good first issue, unlike Consolidate the open Angular dependency bumps into one lockstep PR #442.TranslateServiceinjections onto theI18Ntoken.ngx-translate-i18n.adapter.ts,deployment-translate.loader.tsandapp.config.ts.Acceptance:
http-loadergone, no@ngx-translate/coreimport outside the adapter, nono-restricted-importssuppressions left for it, and lint, both unit suites and themockedandmobilePlaywright projects green.Counts measured on
mainatb1d9280. Background:DOCS/adr/0003-adapter-boundary.md.