From 00da8e0541df3a4f7c3144a7c8ca154884931ef1 Mon Sep 17 00:00:00 2001 From: Alain Schlesser Date: Mon, 31 Aug 2026 10:00:38 +0200 Subject: [PATCH] Skip the SNI test until it can verify SNI again The test requests an HTTPS host and expects a 200, which only demonstrates anything if that host serves a different certificate when no SNI is sent. It no longer does, so a transport which quietly stopped sending SNI would still pass. The host has meanwhile also started answering 403 to every client, including a plain `curl`, so the test fails for reasons entirely unrelated to the library. Pointing it at another host would get the suite green again, but it would also leave a test standing which looks like it covers something it does not. Skipping it says what is actually the case, and keeps the intent visible for whoever picks it up. Refs #1077, which has the measurements and the options for getting real coverage back. --- tests/Transport/BaseTestCase.php | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/tests/Transport/BaseTestCase.php b/tests/Transport/BaseTestCase.php index 03bb657cb..bbe6cf40e 100644 --- a/tests/Transport/BaseTestCase.php +++ b/tests/Transport/BaseTestCase.php @@ -906,6 +906,11 @@ public function testAlternateNameSupport() { * humanmade.com (owned by Human Made and used with permission) points to * CloudFront, and will fail if SNI isn't sent. * + * {@internal Skipped for the time being. The above no longer holds: the host serves the + * same certificate whether SNI is sent or not, so a transport which stopped sending it + * would still pass, and the host has meanwhile started refusing requests outright. + * See https://github.com/WordPress/Requests/issues/1077.} + * * @dataProvider dataSNISupport * * @param array $options Additional options to pass. @@ -913,6 +918,11 @@ public function testAlternateNameSupport() { * @return void */ public function testSNISupport($options) { + $this->markTestSkipped( + 'This test does not verify SNI support anymore.' + . ' See https://github.com/WordPress/Requests/issues/1077' + ); + if ($this->skip_https) { $this->markTestSkipped('SSL support is not available.'); return;