From 0e1e6d42c9296f7cd4f252bd1ab3d968db9d6a75 Mon Sep 17 00:00:00 2001 From: jrfnl Date: Sun, 26 Jul 2026 23:42:15 +0200 Subject: [PATCH] GH Actions: fail "setup-php" if requested tooling could not be installed Setup-PHP will normally "gracefully" show a warning and not fail the build when an extension or tool failed to install. In most cases, this is not particularly useful as that means that either there will be a failure later on in the build due to the extension or tool missing, or the build will not be representative of what is supposed to be tested. This commit changes this behaviour to fail select builds at the `setup-php` step, which also makes debugging these type of build failures much more straight-forward. Ref: https://github.com/shivammathur/setup-php?tab=readme-ov-file#fail-fast-optional --- .github/workflows/lint.yml | 2 ++ .github/workflows/quicktest.yml | 2 ++ .github/workflows/test.yml | 2 ++ 3 files changed, 6 insertions(+) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 37f037c8d..5c97ac655 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -38,6 +38,8 @@ jobs: ini-values: error_reporting=-1, display_errors=On, display_startup_errors=On, log_errors_max_len=0 coverage: none tools: cs2pr + env: + fail-fast: true # Install dependencies and handle caching in one go. # @link https://github.com/marketplace/actions/install-php-dependencies-with-composer diff --git a/.github/workflows/quicktest.yml b/.github/workflows/quicktest.yml index c93bf4798..5d8f7ca42 100644 --- a/.github/workflows/quicktest.yml +++ b/.github/workflows/quicktest.yml @@ -37,6 +37,8 @@ jobs: php-version: ${{ matrix.php }} ini-values: zend.assertions=1, error_reporting=-1, display_errors=On, display_startup_errors=On, log_errors_max_len=0 coverage: none + env: + fail-fast: true # At least one test needs a non-en_US locale to be available, so make sure it is. - name: Install locales diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index dc02afe9c..5926c602a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -49,6 +49,8 @@ jobs: ini-values: zend.assertions=1, error_reporting=-1, display_errors=On, display_startup_errors=On, log_errors_max_len=0 coverage: ${{ matrix.coverage && 'xdebug' || 'none' }} tools: cs2pr + env: + fail-fast: true # At least one test needs a non-en_US locale to be available, so make sure it is. - name: Install locales