Skip to content

Requests class: review and improve decompression methods #596

Description

@jrfnl

As per #595:

The methods covered via the DecompressionTest test class need a lot more tests, in particular the Requests::compatible_gzinflate() method, which includes code paths currently completely untested and handling of ZIP file format, which when called from Requests::decompress() (which is the only way it is called from within the Requests library itself), can never be reached as the "magic markers" used by ZIP are not included in the Requests::$magic_compression_headers property.

A future iteration should do a more in-depth review of these two method to determine what should be handled by each method and add additional tests.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions