Skip to content

'break' on non-multiple of 8 offsets leaves garbage data #2

Description

@amj

according to the spec as i understand it, the bulk-update commands that operate on 8x8 blocks can pass along x,y offsets that aren't actually multiples of 8. Right now, untz_monome will break if it sees those, leaving the remaining serial bytes specifying the data left in the buffer.

So, any 'break' in that switch statement can potentially leave junk in the incoming serial stream to foul up the next command.

this is based on my reading of http://monome.org/docs/serial.txt, which seems a little obtuse, but hey.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions