Skip to content

Use SIGKILL or SIGTERM for killing, not SIGABRT #169

Description

@BenWiederhake

spectrum2 uses SIGABRT to kill child processes at least in NetworkPluginServer.cpp.

This makes it very non-obvious to figure out what happened, because SIGABRT usually comes from a program-internal call to abort(), which usually comes from a failing assert(), which meant that #146 and https://github.com/vysheng/tgl/issues/116#issuecomment-255728825 were quite an adventure, whereas SIGKILL would have immediately conveyed what is happening.

Please use SIGKILL (9) or SIGTERM (15) for this.

I won't open an issue for this discussion about timeouts (both tgp and spectrum2), so if anyone cares, open an additional issue for that.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions