From ea738327e75b0593938d1f58dadbdaafd8d8c32d Mon Sep 17 00:00:00 2001 From: lawrencejames24 Date: Mon, 24 Aug 2026 13:43:07 -0600 Subject: [PATCH] Isolate provider search failures instead of failing the whole request searchSeriesMetadata launched each provider's search concurrently but then awaited them sequentially without catching per-provider errors, so a single failing provider (e.g. one returning 403) would throw and discard results from every other provider that had already succeeded, surfacing as a 500 to callers even though most providers were fine. Now each provider's result is caught individually and logged on failure, contributing only its own results to the aggregate instead of aborting the whole search. Fixes #216 --- .../mediaserver/metadata/MetadataService.kt | 20 +++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/komf-mediaserver/src/commonMain/kotlin/snd/komf/mediaserver/metadata/MetadataService.kt b/komf-mediaserver/src/commonMain/kotlin/snd/komf/mediaserver/metadata/MetadataService.kt index 129f31ab..2c60a248 100644 --- a/komf-mediaserver/src/commonMain/kotlin/snd/komf/mediaserver/metadata/MetadataService.kt +++ b/komf-mediaserver/src/commonMain/kotlin/snd/komf/mediaserver/metadata/MetadataService.kt @@ -68,17 +68,25 @@ class MetadataService( libraryId: MediaServerLibraryId ): Collection { val providers = metadataProviders.providers(libraryId.value) - - return providers - .map { coroutineScope.async { it.searchSeries(seriesName) } } - .flatMap { it.await() } + return searchSeriesMetadata(seriesName, providers) } suspend fun searchSeriesMetadata(seriesName: String): Collection { val providers = metadataProviders.defaultProvidersList() + return searchSeriesMetadata(seriesName, providers) + } + + private suspend fun searchSeriesMetadata( + seriesName: String, + providers: Collection + ): Collection { return providers - .map { coroutineScope.async { it.searchSeries(seriesName) } } - .flatMap { it.await() } + .map { provider -> provider to coroutineScope.async { provider.searchSeries(seriesName) } } + .flatMap { (provider, deferred) -> + runCatching { deferred.await() } + .onFailure { e -> logger.error(e) { "search failed for provider ${provider.providerName()}" } } + .getOrDefault(emptyList()) + } } suspend fun getSeriesCover(