Skip to content

Unsound usages of unsafe implementation about c_void #129

Description

@llooFlashooll

Hi, I am scanning this crate in the latest version using my own static analyzer tool.

Unsafe pointer conversion is found at:

unsafe fn output_from_raw(
        pointer: NonNull<c_void>,
        _sample_count: u32,
    ) -> Self::OutputPortType {
        Cell::from_mut(&mut *(pointer.as_ptr() as *mut f32))
    }

This unsound implementation would create memory issues such as overflow, underflow, or misalignment. The attacker can manipulate the argument pointer associated with the c_void pointer with an unexpected type, size, or alignment, which can lead to an out-of-bounds memory access bug. The c_void pointer is directly cast to *mut f32 and dereferenced, which can further corrupt the C/C++ code.

This would cause undefined behaviors in Rust. Adversaries can manipulate the associated pointer argument to cause memory safety bugs. I am reporting this issue for your attention.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions