From 4c646667d2e3fa68defe68d687d1997ed6ff3aac Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Fri, 7 Aug 2026 16:17:38 +0000
Subject: [PATCH] build(testing): consume JustDummies as a published package
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Steps 1-4 and 7 of the cutover ADR-0069 prescribes, now that
JustDummies 1.0.0-preview.1 is on nuget.org.

The four ProjectReferences become PackageReferences, and the four analyzer
references go with them: the package carries the 28 analyzers under
analyzers/dotnet/cs, verified on the published artifact rather than assumed.

FirstClassErrors.Testing loses IncludeJustDummiesInPackage and its
PrivateAssets=all. Its package stops smuggling JustDummies.dll into lib/ and
declares the dependency instead — which is the point of the change, per ADR-0069:
a consumer who also references JustDummies directly can no longer end up with two
copies at different versions and no diagnostic. The dependency is on a PRERELEASE,
deliberately and temporarily, so the split can happen before JustDummies reaches
1.0 stable; FirstClassErrors.Testing cannot ship a stable version until it does.

The seven JustDummies projects, the dum train and the workflows stay for now:
ADR-0069 orders the deletion last, after the consumers no longer reference them.

Refs: #404
---
 Directory.Packages.props                      |  1 +
 ...ClassErrors.RequestBinder.UnitTests.csproj | 15 +++-----
 .../FirstClassErrors.Testing.UnitTests.csproj | 11 ++----
 .../FirstClassErrors.Testing.csproj           | 34 ++++++-------------
 .../FirstClassErrors.UnitTests.csproj         | 17 ++++------
 5 files changed, 25 insertions(+), 53 deletions(-)

diff --git a/Directory.Packages.props b/Directory.Packages.props
index 2ebcc231..d1bff9da 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -29,6 +29,7 @@
     <PackageVersion Include="coverlet.collector" Version="10.0.1" />
     <PackageVersion Include="FsCheck" Version="3.3.4" />
     <PackageVersion Include="JetBrains.Annotations" Version="2026.2.0" />
+    <PackageVersion Include="JustDummies" Version="1.0.0-preview.1" />
     <PackageVersion Include="Microsoft.CodeAnalysis.Analyzers" Version="5.6.0" />
     <PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="5.6.0" />
     <PackageVersion Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="5.6.0" />
diff --git a/FirstClassErrors.RequestBinder.UnitTests/FirstClassErrors.RequestBinder.UnitTests.csproj b/FirstClassErrors.RequestBinder.UnitTests/FirstClassErrors.RequestBinder.UnitTests.csproj
index ac0c5613..1e29a580 100644
--- a/FirstClassErrors.RequestBinder.UnitTests/FirstClassErrors.RequestBinder.UnitTests.csproj
+++ b/FirstClassErrors.RequestBinder.UnitTests/FirstClassErrors.RequestBinder.UnitTests.csproj
@@ -26,17 +26,12 @@
     <ProjectReference Include="..\FirstClassErrors\FirstClassErrors.csproj" />
     <ProjectReference Include="..\FirstClassErrors.RequestBinder\FirstClassErrors.RequestBinder.csproj" />
     <ProjectReference Include="..\FirstClassErrors.Testing\FirstClassErrors.Testing.csproj" />
-    <!-- Direct reference: Testing references JustDummies privately (PrivateAssets=all), so it does not flow
-         transitively; this project uses JustDummies.Any.* directly for arbitrary primitives. -->
-    <ProjectReference Include="..\JustDummies\JustDummies.csproj" />
+    <!-- Declared here although Testing now flows it transitively: this project uses JustDummies.Any.*
+         directly, and a direct use gets a direct reference. -->
+    <PackageReference Include="JustDummies" />
 
-    <!-- Run the JustDummies analyzers on this project (ADR-0061): OutputItemType=Analyzer loads them at
-         build and in the IDE, ReferenceOutputAssembly=false keeps them off the runtime graph, and
-         PrivateAssets=all stops the reference from reaching a consumer of this project. -->
-    <ProjectReference Include="..\JustDummies.Analyzers\JustDummies.Analyzers.csproj"
-                      OutputItemType="Analyzer"
-                      ReferenceOutputAssembly="false"
-                      PrivateAssets="all" />
+    <!-- The JustDummies analyzers (ADR-0061) need no reference of their own: the package carries them
+         under analyzers/dotnet/cs, so a PackageReference loads them at build and in the IDE. -->
   </ItemGroup>
 
   <ItemGroup>
diff --git a/FirstClassErrors.Testing.UnitTests/FirstClassErrors.Testing.UnitTests.csproj b/FirstClassErrors.Testing.UnitTests/FirstClassErrors.Testing.UnitTests.csproj
index 098a74d5..bb10cede 100644
--- a/FirstClassErrors.Testing.UnitTests/FirstClassErrors.Testing.UnitTests.csproj
+++ b/FirstClassErrors.Testing.UnitTests/FirstClassErrors.Testing.UnitTests.csproj
@@ -25,15 +25,10 @@
   <ItemGroup>
     <ProjectReference Include="..\FirstClassErrors\FirstClassErrors.csproj" />
     <ProjectReference Include="..\FirstClassErrors.Testing\FirstClassErrors.Testing.csproj" />
-    <ProjectReference Include="..\JustDummies\JustDummies.csproj" />
+    <PackageReference Include="JustDummies" />
 
-    <!-- Run the JustDummies analyzers on this project (ADR-0061): OutputItemType=Analyzer loads them at
-         build and in the IDE, ReferenceOutputAssembly=false keeps them off the runtime graph, and
-         PrivateAssets=all stops the reference from reaching a consumer of this project. -->
-    <ProjectReference Include="..\JustDummies.Analyzers\JustDummies.Analyzers.csproj"
-                      OutputItemType="Analyzer"
-                      ReferenceOutputAssembly="false"
-                      PrivateAssets="all" />
+    <!-- The JustDummies analyzers (ADR-0061) need no reference of their own: the package carries them
+         under analyzers/dotnet/cs, so a PackageReference loads them at build and in the IDE. -->
   </ItemGroup>
 
   <ItemGroup>
diff --git a/FirstClassErrors.Testing/FirstClassErrors.Testing.csproj b/FirstClassErrors.Testing/FirstClassErrors.Testing.csproj
index 6f5c826b..eb5fdf28 100644
--- a/FirstClassErrors.Testing/FirstClassErrors.Testing.csproj
+++ b/FirstClassErrors.Testing/FirstClassErrors.Testing.csproj
@@ -56,32 +56,18 @@
 
   <ItemGroup>
     <ProjectReference Include="..\FirstClassErrors\FirstClassErrors.csproj" />
-    <!-- JustDummies backs the arbitrary-value factories (ADR-0026). It is not yet on NuGet (ADR-0011), so
-         reference it privately and embed its assembly in this package (see the pack target below);
-         switch to a NuGet PackageReference once JustDummies is published. -->
-    <ProjectReference Include="..\JustDummies\JustDummies.csproj" PrivateAssets="all" />
-
-    <!-- Run the JustDummies analyzers on this project (ADR-0061): OutputItemType=Analyzer loads them at
-         build and in the IDE, ReferenceOutputAssembly=false keeps them off the runtime graph, and
-         PrivateAssets=all stops the reference from reaching a consumer of this project. -->
-    <ProjectReference Include="..\JustDummies.Analyzers\JustDummies.Analyzers.csproj"
-                      OutputItemType="Analyzer"
-                      ReferenceOutputAssembly="false"
-                      PrivateAssets="all" />
+    <!-- JustDummies backs the arbitrary-value factories (ADR-0026), and is now a published package.
+         Declared WITHOUT PrivateAssets, unlike every other reference here: a consumer restoring this
+         package must get JustDummies too, since the factories call into it at runtime. That makes it a
+         real, visible dependency where it used to be an assembly smuggled into lib/ — and it is a
+         PRERELEASE dependency, deliberately and temporarily, so the split can happen before JustDummies
+         reaches 1.0 stable. This package cannot ship a stable version until that one does. -->
+    <PackageReference Include="JustDummies" />
+
+    <!-- The JustDummies analyzers (ADR-0061) need no reference of their own: the package carries them
+         under analyzers/dotnet/cs, so the PackageReference above loads them at build and in the IDE. -->
   </ItemGroup>
 
-  <!-- While JustDummies is unpublished, carry JustDummies.dll inside this package's lib/ so a consumer restores it
-       transparently. PrivateAssets=all above emits no JustDummies <dependency>, so the embedded copy is the
-       only one. Remove this whole block when JustDummies moves to a NuGet PackageReference (ADR-0026 follow-up). -->
-  <PropertyGroup>
-    <TargetsForTfmSpecificBuildOutput>$(TargetsForTfmSpecificBuildOutput);IncludeJustDummiesInPackage</TargetsForTfmSpecificBuildOutput>
-  </PropertyGroup>
-  <Target Name="IncludeJustDummiesInPackage">
-    <ItemGroup>
-      <BuildOutputInPackage Include="$(OutputPath)JustDummies.dll" />
-    </ItemGroup>
-  </Target>
-
   <ItemGroup>
     <!-- Embed an SPDX SBOM (software bill of materials) inside the package at pack time
          (_manifest/spdx_2.2/manifest.spdx.json), so the inventory of files and dependencies travels with
diff --git a/FirstClassErrors.UnitTests/FirstClassErrors.UnitTests.csproj b/FirstClassErrors.UnitTests/FirstClassErrors.UnitTests.csproj
index a26706cc..2b8b6632 100644
--- a/FirstClassErrors.UnitTests/FirstClassErrors.UnitTests.csproj
+++ b/FirstClassErrors.UnitTests/FirstClassErrors.UnitTests.csproj
@@ -29,17 +29,12 @@
   <ItemGroup>
     <ProjectReference Include="..\FirstClassErrors\FirstClassErrors.csproj" />
     <ProjectReference Include="..\FirstClassErrors.Testing\FirstClassErrors.Testing.csproj" />
-    <!-- Direct reference: Testing references JustDummies privately (PrivateAssets=all), so it does not flow
-         transitively; this project uses JustDummies.Any.* directly for arbitrary primitives. -->
-    <ProjectReference Include="..\JustDummies\JustDummies.csproj" />
-
-    <!-- Run the JustDummies analyzers on this project (ADR-0061): OutputItemType=Analyzer loads them at
-         build and in the IDE, ReferenceOutputAssembly=false keeps them off the runtime graph, and
-         PrivateAssets=all stops the reference from reaching a consumer of this project. -->
-    <ProjectReference Include="..\JustDummies.Analyzers\JustDummies.Analyzers.csproj"
-                      OutputItemType="Analyzer"
-                      ReferenceOutputAssembly="false"
-                      PrivateAssets="all" />
+    <!-- Declared here although Testing now flows it transitively: this project uses JustDummies.Any.*
+         directly, and a direct use gets a direct reference. -->
+    <PackageReference Include="JustDummies" />
+
+    <!-- The JustDummies analyzers (ADR-0061) need no reference of their own: the package carries them
+         under analyzers/dotnet/cs, so a PackageReference loads them at build and in the IDE. -->
   </ItemGroup>
 
   <ItemGroup>