⚡️ Remove useless clone

[lrazovic]

This pull request introduces several updates across multiple files to improve code consistency, enhance performance, and adopt best practices. Key changes include enforcing stricter linting rules, replacing redundant .clone() calls with direct references, adding const constructors for better compile-time optimizations, and removing unnecessary imports. These changes aim to streamline the codebase and improve maintainability.

Linting and Code Quality Improvements:

• Updated Cargo.toml to enforce stricter linting by changing redundant_clone from "warn" to "deny" and adding a new lint rule missing-const-for-fn set to "warn".

Performance Optimizations:

• Replaced .clone() calls with direct references or moved values where cloning was unnecessary, e.g., in pallets/funding/src/functions/1_application.rs, pallets/funding/src/functions/3_auction.rs, and pallets/funding/src/instantiator/chain_interactions.rs. [1] [2] [3]

Compile-Time Improvements:

• Added const constructors for several structs and utility functions across the codebase, such as CheckNonce, EvaluationParams, and UserToFundingAsset, enabling compile-time evaluation where possible. [1] [2] [3]

Simplification of Code:

• Removed unnecessary .clone() calls in functional operations, such as group_by and map, to simplify logic and reduce redundancy in pallets/funding/src/instantiator/calculations.rs. [1] [2]
• Replaced wildcard imports with explicit imports for better clarity and to avoid potential namespace conflicts.

Miscellaneous Enhancements:

• Converted several methods in pallets/funding/src/types.rs to const functions, such as usd_ticket_above_minimum_per_participation and multiplier, to improve performance and enable compile-time checks. [1] [2]

[lrazovic]

• [DNM] Instantiator refactor and cleanup #494
• Bid with receiving account: xcm support #490
• Possible bug fixes #491
• feat: specify amount to invest #489
• 🎨 Refactor the Price Buckets #488
• ⚡️ Remove AccountId and id from stored value #487
• ✨ Use PLMC amount in Evaluation #484
• ⚡️ Remove useless clone #486 👈 (View in Graphite)
• 🎨 Simplify the acceptable_assets #485
• 🎨 Macros update and documentation #483
• ⬆️ Bump to Polkadot SDK stable 2503-5 #482 : 1 other dependent PR (#493 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

This PR removes unnecessary .clone() calls and marks simple constructors and accessors as const fn to enforce immutability at compile time, while tightening the redundant_clone lint.

• Removed redundant clone() calls across runtime and pallet code.
• Added const fn qualifiers to simple constructors and methods.
• Updated Cargo.toml to deny redundant clones and warn on missing const fn.

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
runtimes/polimec/src/xcm_config.rs	Removed useless clone and switched to is_some_and
polimec-common/common/src/lib.rs	Made from(Vec<>) constructor a const fn
pallets/proxy-bonding/src/functions.rs	Removed redundant .clone() on treasury and account parameters
pallets/on-slash-vesting/src/lib.rs	Changed on_slash to take &Balance and updated usages
pallets/linear-release/src/lib.rs	Converted max_vesting_schedules to const fn
pallets/funding/src/types.rs	Added const fn to multiple constructors and predicate methods
pallets/funding/src/instantiator/types.rs	Marked all .new methods as const fn
pallets/funding/src/instantiator/mod.rs	Removed clippy allow for wildcard imports
pallets/funding/src/instantiator/chain_interactions.rs	Removed redundant clones, made new a const fn
pallets/funding/src/instantiator/calculations.rs	Dropped unnecessary clone before grouping bids
pallets/funding/src/functions/misc.rs	Removed .clone() on polimec_account
pallets/funding/src/functions/5_settlement.rs	Removed clones on escrow_account and slashed_amount
pallets/funding/src/functions/3_auction.rs	Dropped .clone() on bidder in event emission
pallets/funding/src/functions/1_application.rs	Removed clones on issuer and did in project creation
pallets/dispenser/src/extensions.rs	Made constructor from(nonce) a const fn
Cargo.toml	Set redundant_clone = "deny" and added missing-const-for-fn

Comments suppressed due to low confidence (2)

pallets/funding/src/instantiator/mod.rs:15

• The wildcard imports here are no longer exempted by clippy, which may trigger lint errors. Consider replacing * imports with specific items or re-adding a lint allowance for wildcard imports.

use crate::{traits::*, *};

pallets/funding/src/instantiator/chain_interactions.rs:15

• This const fn invokes RefCell::new(0u64), which is not a const fn in the standard library. It will fail to compile. Either revert to a non-const function or ensure all called functions are const-compatible.

pub const fn new(ext: OptionalExternalities) -> Self {

[lrazovic]

Merge activity

• Aug 4, 7:49 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Aug 4, 7:57 AM UTC: Graphite rebased this pull request as part of a merge.
• Aug 4, 7:58 AM UTC: @lrazovic merged this pull request with Graphite.