Skip to content

Update golang toolchain - #2018

Merged
henry118 merged 3 commits into
NVIDIA:mainfrom
henry118:update-go
Aug 24, 2026
Merged

Update golang toolchain#2018
henry118 merged 3 commits into
NVIDIA:mainfrom
henry118:update-go

Conversation

@henry118

@henry118 henry118 commented Aug 21, 2026

Copy link
Copy Markdown
Member

Go 1.25 is EOL.

  • Bump the minimum required toolchain to 1.26
  • Bump CI version (build/test/release) to 1.27

@coveralls

coveralls commented Aug 21, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 32516771210

Coverage decreased (-0.4%) to 43.69%

Details

  • Coverage decreased (-0.4%) from the base build.
  • Patch coverage: 2 uncovered changes across 2 files (1 of 3 lines covered, 33.33%).
  • 5 coverage regressions across 5 files.

Uncovered Changes

File Changed Covered %
cmd/nvidia-cdi-hook/cudacompat/cudacompat.go 2 1 50.0%
pkg/nvcdi/driver-wsl.go 1 0 0.0%

Coverage Regressions

5 previously-covered lines in 5 files lost coverage.

File Lines Losing Coverage Coverage
cmd/nvidia-ctk-installer/toolkit/toolkit.go 1 40.51%
cmd/nvidia-ctk/runtime/configure/configure.go 1 71.83%
internal/platform-support/dgpu/dgpu.go 1 69.88%
pkg/system/nvdevices/devices.go 1 76.67%
pkg/system/nvmodules/modules.go 1 89.74%

Coverage Stats

Coverage Status
Relevant Lines: 13415
Covered Lines: 5861
Line Coverage: 43.69%
Coverage Strength: 0.44 hits per line

💛 - Coveralls

@henry118 henry118 self-assigned this Aug 21, 2026
@henry118 henry118 changed the title Update minimum go toolchain to 1.26 Update golang toolchain Aug 21, 2026
Signed-off-by: Henry Wang <henrwang@nvidia.com>
Signed-off-by: Henry Wang <henrwang@nvidia.com>
Signed-off-by: Henry Wang <henrwang@nvidia.com>
Comment thread go.mod
@tariq1890
tariq1890 requested a review from cdesiniotis August 21, 2026 23:03
@henry118
henry118 merged commit 1e633f1 into NVIDIA:main Aug 24, 2026
21 checks passed
@henry118
henry118 deleted the update-go branch August 24, 2026 20:31
@henry118

Copy link
Copy Markdown
Member Author

/cherry-pick release-1.20

@github-actions

Copy link
Copy Markdown

🤖 Backport PR created for release-1.20: #2024 ⚠️ (has conflicts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants