From d8e2b48dc1e30cfeeb36f80e11f9e076bd54c475 Mon Sep 17 00:00:00 2001 From: Danil Silantyev Date: Sat, 15 Aug 2026 06:30:25 +0500 Subject: [PATCH] chore(actions): drop a helper nothing calls MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit RunStepsContaining shipped with the workflow model and was never called. That is the same shape this release spent its time removing everywhere else — a field required and never read, a check that could not fail for the reason it claimed — and leaving it in would be keeping the thing I had just finished arguing against. Worth naming the detection gap rather than implying it is covered: neither go vet nor staticcheck reports this. An exported identifier inside an internal/ package is not treated as unused, even though nothing outside the module can reach it, so this class is currently found by looking. --- CHANGELOG.md | 9 +++++++++ internal/actions/workflow.go | 11 ----------- 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a1e9286..5b10757 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,15 @@ contract. ## [Unreleased] +### Removed + +- `actions.Job.RunStepsContaining` is gone. It was added with the workflow model + and never called, which is the shape this release spent its time removing + everywhere else. Neither `go vet` nor `staticcheck` reports it, because an + exported identifier in an `internal/` package is not treated as unused even + though nothing outside the module can reach it — so this class is currently + found by looking rather than by a gate. + ## [0.2.0] - 2026-08-15 A minor bump because the contract breaks. Everything here came out of a forensic diff --git a/internal/actions/workflow.go b/internal/actions/workflow.go index 4f151f1..ce92eaf 100644 --- a/internal/actions/workflow.go +++ b/internal/actions/workflow.go @@ -182,17 +182,6 @@ func (j *Job) StepUsing(prefix string) (Step, bool) { return Step{}, false } -// RunStepsContaining returns every enabled step whose run script contains token. -func (j *Job) RunStepsContaining(token string) []Step { - var steps []Step - for _, step := range j.Steps { - if step.Enabled() && step.Run != "" && strings.Contains(step.Run, token) { - steps = append(steps, step) - } - } - return steps -} - // UsesActions returns the `uses` reference of every enabled step. func (j *Job) UsesActions() []string { refs := make([]string, 0, len(j.Steps))