Skip to content

notebooks/template_qc.qmd fails without 'alias' column in samplesheet.csv #94

Description

@kieran-redpath

create_diversity_plot() in notebooks/template_qc.qmd doesn't guard against a missing alias column at line 280 (also line 306), leading to this error message in nextflow.log if the alias column is missing and --alias_col is not defined:

ValueError: Value of 'hover_data_0' is not the name of a column in 'data_frame'.
Expected one of ['sample', 'shannon_entropy', 'inverse_simpson', 'gini_coefficient',
'hill_q0', 'hill_q1', 'hill_q2', 'patient', 'timepoint', 'origin', 'file']
but received: alias

I don't think this is intended behaviour, as tests/fixtures/valid_samplesheet.csv does not include the alias column, and other plotting functions in template_qc.qmd include a "if 'alias' in plot_df.columns" guard.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions