Make test synchronization deterministic - #1346
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1346 +/- ##
=======================================
Coverage 88.51% 88.52%
=======================================
Files 31 31
Lines 11955 11961 +6
=======================================
+ Hits 10582 10588 +6
Misses 1373 1373 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Replace sleeps, polling deadlines, and elapsed-time assertions with lifecycle signals, exact protocol reads, and expired deadlines. Add a policy test and contributor guidance to keep the suite deterministic across variable CI runner load.
Add lifecycle barriers and private clock and wait seams so deterministic tests still execute active wait, wake, handoff, and shutdown paths. Restore project coverage without reintroducing elapsed-time coordination.
quinnj
force-pushed
the
codex/deterministic-test-synchronization
branch
from
August 7, 2026 20:35
57ed420 to
eca220c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
GitHub Actions can pause Julia tasks for unpredictable periods. The test suite used short sleeps, polling deadlines, and elapsed-time limits as proxies for protocol state. Runner scheduling delays could therefore fail correct HTTP behavior. Some timing guards could also hide a real deadlock instead of identifying the missing lifecycle signal.
The first CI run also exposed a coverage regression. Some rewritten deadline tests used already-expired deadlines and no longer executed active wait and wake paths. The follow-up adds deterministic lifecycle barriers and private clock and wait seams. It restores these paths without wall-clock coordination.
Validation
git diff --checkCo-authored by Codex