The histogram sits over the inventory panel, which works well while the inventory is open. When I close the inventory the panel goes away but the histogram stays, so the tick marks are left floating over the game world with nothing behind them.
I'd like an option for the overlay to hide whenever the inventory is hidden, so it comes and goes with the rest of the interface.
As far as I can tell this isn't currently possible. HistogramOverlay is constructed with only HistogramConfig, so it has no Client to ask about widget state, and render draws unconditionally with no early return. There's no config key that could drive one either.
Suggested shape:
- A boolean in the Panel section, e.g.
Hide When Inventory Closed, defaulting to off so nothing changes for existing users
- Pass the plugin's already-injected
Client into HistogramOverlay
- Return
null early from render when the toggle is on and the inventory widget is hidden
I've also opened a PR with one implementation of this, but no strong feelings about the approach if you'd rather do it differently.
The histogram sits over the inventory panel, which works well while the inventory is open. When I close the inventory the panel goes away but the histogram stays, so the tick marks are left floating over the game world with nothing behind them.
I'd like an option for the overlay to hide whenever the inventory is hidden, so it comes and goes with the rest of the interface.
As far as I can tell this isn't currently possible.
HistogramOverlayis constructed with onlyHistogramConfig, so it has noClientto ask about widget state, andrenderdraws unconditionally with no early return. There's no config key that could drive one either.Suggested shape:
Hide When Inventory Closed, defaulting to off so nothing changes for existing usersClientintoHistogramOverlaynullearly fromrenderwhen the toggle is on and the inventory widget is hiddenI've also opened a PR with one implementation of this, but no strong feelings about the approach if you'd rather do it differently.