Skip to content

Timber - Type Inconsistencies #262

Description

@pchryss

While taking a look through the Timber repository, I quickly noticed some type inconsistencies that I'm sure are making the repo difficult to maintain.

As an example, we have a "Project" type at src/types/Project.ts that is not being used in severall files that work with "Projects". e.g. ProjectCard.tsx, Dashboard.tsx, etc

As another example, we have a "User" type at src/types/User.ts.
If you look at Dashboard.tsx, you will find that user is defined as an "any" type, while it is defined in "ProjectCard.tsx" as a "User" type.

If HexLabs is planning on building off of this Timber repository in the future, I think it would be worth setting some time aside towards cleaning it up to make development easier in the future, especially for new members

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions