Skip to content

No user_id enrichment option for batch getActivities #608

Description

@lavirez

Hey there I have used your SDK in the following code, I used user_id and it was just fine it filtered the ownReactions by the given user_id.

(async function () {
  try {
    const response = await client.getActivities({
      ids: ['<activity_id>'],
        user_id:
        '<user_id>',
      reactions: {
        
        recent: true,
        counts: true,
        own: true,
        kind: true,
      },
    });
  } catch (error) {
    console.log(error);
  }
})();

However in SDK source code the EnrichOptions is defined as following:

export type EnrichOptions = {
  enrich?: boolean;
  ownReactions?: boolean; // best not to use it, will be removed by client.replaceReactionOptions()
  reactionKindsFilter?: string[]; // TODO: add support for array sample: kind,kind,kind
  recentReactionsLimit?: number;
  withOwnChildren?: boolean;
  withOwnReactions?: boolean;
  withReactionCounts?: boolean;
  withRecentReactions?: boolean;
  withUserId?: string;
};

There's no user_id what's the deal with that?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions