Multiline matches no longer apply highlight on every matching line

[DeltaRazero]

Hello,

I just migrated from the old abandoned Todo Tree extension. With the following configuration snippet, the old extension highlighted multiple lines in the editor:

{
  "todo-tree.ripgrep.ripgrepArgs": "--max-columns=200 --no-config --pcre2",
  "todo-tree.regex.regex": "((#|\\/\\/|--|;) *)($TAGS)[: ]+.*(\\r?\\n *\\2.*)*|((\\/\\*|<!--)(.(?!(\\*\\/|-->)))*)(\\r?\\n(.(?!(\\*\\/|-->)))*){0,1}($TAGS)[\\s\\S]*?(\\*\\/|-->)",
  "todo-tree.highlights.enabled": true,
  "todo-tree.highlights.useColourScheme": true,
  "todo-tree.highlights.defaultHighlight": {
    "type": "whole-line",
    "borderRadius": "0",
    "rulerLane": "center"
  },
}

After having migrated to the new extension, I can see that the matching itself still works by checking it in the pane:

But the highlight itself is only applied to the first line, instead of multiple lines:

[Ren-fight]

use "type": "line"

[DeltaRazero]

use "type": "line"

Unfortunately doesn't make a difference.

[Ren-fight]

Perhaps you can use customization.
"better-todo-tree.highlights.customHighlight": {
"TODO": {
"icon": "checkbox",
"type": "line",
"foreground": "#fff",
"background": "#2196F3",
"opacity": 80,
"iconColor": "#2196F3",
"gutterIcon": true
},
}

[FanaticPythoner]

First, I wanted to say, sorry for being AWOL for a while. Lots of things moved in my personal, and professional, life, including expecting, unexpectedly, yet happily welcoming such, a new member in the family. I will get back to Better Todo Tree in the very short term. Thank you for you guys' understanding ❤️

[FanaticPythoner]

Even though I've sent tthis comment in all open issues at this time on BTT, be assured that I will carefully review your spefific case and answer you, in the next few days, to a week, personally and appropriately. Thank you, and you surpport means a LOT!!!!!

[Aetherinox]

Also came here because I'm getting the exact same thing. The single top line is highlighting, everything else is ignored.

In the original extension, whole-line worked well.

[Aetherinox]

Note, I went into the dist/extension.js file, and modified the code. Too lazy right now to re-build my own.

I fixed it by modifying:

Find:

                            else if ("line" === h || "whole-line" === h)
                            {
                                var u = e.document.positionAt(n.tagStartOffset).line,
                                    d = new i.Position(u, 0),
                                    p = e.document.lineAt(u).range.end;
                                t(l, d, p)
                            }

Replace With:

                            else if ("line" === h)
                            {
                                var u = e.document.positionAt(n.tagStartOffset).line,
                                    d = new i.Position(u, 0),
                                    p = e.document.lineAt(u).range.end;
                                t(l, d, p)
                            }
                            else if ("whole-line" === h)
                            {
                                var wholeLineStartLine = e.document.positionAt(n.commentStartOffset).line,
                                    wholeLineStart = new i.Position(wholeLineStartLine, 0),
                                    wholeLineEndLine = e.document.positionAt(Math.max(n.commentStartOffset, n.commentEndOffset - 1)).line,
                                    wholeLineEnd = e.document.lineAt(wholeLineEndLine).range.end;
                                t(l, wholeLineStart, wholeLineEnd)
                            }

It now behaves as it did in the original plugin, if you use something such as the following, and have declared whole-line:

    "better-todo-tree.highlights.customHighlight": {
        "# #": {
            "foreground": "#8f86a8",
            "background": "#1c1829",
            "opacity": 100,
            "type": "whole-line",
            "hideFromTree": true,
            "hideFromStatusBar": true,
            "hideFromActivityBar": true
        }
    },

Performance on this fork is much better. No flickering. Only issue was that one quirk.