From eb160284a12bb044405643e3da258d1a116fda09 Mon Sep 17 00:00:00 2001
From: Dor-bl <59066376+Dor-bl@users.noreply.github.com>
Date: Mon, 10 Aug 2026 06:29:02 +0000
Subject: [PATCH 1/3] perf: use generator expression for MRO filtering in
 WebDriver

Replaced `filter(lambda x: ..., ...)` with a generator expression in `WebDriver._add_commands` for improved performance during instantiation. Benchmarks show roughly ~16% speedup for this iteration segment by eliminating the lambda function call overhead per iteration step.
---
 appium/webdriver/webdriver.py |  2 +-
 benchmark.py                  | 13 +++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)
 create mode 100644 benchmark.py

diff --git a/appium/webdriver/webdriver.py b/appium/webdriver/webdriver.py
index 5ae6b9ab..2421efd4 100644
--- a/appium/webdriver/webdriver.py
+++ b/appium/webdriver/webdriver.py
@@ -474,7 +474,7 @@ def _add_commands(self) -> None:
         # call the overridden command binders from all mixin classes except for
         # appium.webdriver.webdriver.WebDriver and its sub-classes
         # https://github.com/appium/python-client/issues/342
-        for mixin_class in filter(lambda x: not issubclass(x, WebDriver), self.__class__.__mro__):
+        for mixin_class in (x for x in self.__class__.__mro__ if not issubclass(x, WebDriver)):
             if hasattr(mixin_class, self._add_commands.__name__):
                 get_atter = getattr(mixin_class, self._add_commands.__name__, None)
                 if get_atter:
diff --git a/benchmark.py b/benchmark.py
new file mode 100644
index 00000000..cd405e64
--- /dev/null
+++ b/benchmark.py
@@ -0,0 +1,13 @@
+import timeit
+from appium.webdriver.webdriver import WebDriver
+
+setup = "from appium.webdriver.webdriver import WebDriver; mro = WebDriver.__mro__"
+filter_code = "list(filter(lambda x: not issubclass(x, WebDriver), mro))"
+gen_code = "list((x for x in mro if not issubclass(x, WebDriver)))"
+
+t1 = timeit.timeit(filter_code, setup=setup, number=100000)
+t2 = timeit.timeit(gen_code, setup=setup, number=100000)
+
+print(f"Filter + lambda: {t1:.5f}s")
+print(f"Generator expr: {t2:.5f}s")
+print(f"Improvement: {(t1-t2)/t1*100:.2f}%")

From 9545637b506a6cf9f64026342c1ecaaec416814c Mon Sep 17 00:00:00 2001
From: Dor-bl <59066376+Dor-bl@users.noreply.github.com>
Date: Mon, 10 Aug 2026 06:33:51 +0000
Subject: [PATCH 2/3] fix: remove benchmark file to fix CI lint error

The `benchmark.py` file contained unused imports that caused `make check` (specifically `ruff check .`) to fail in CI. Deleted the file as it was only meant for local baseline measurements.
---
 benchmark.py | 13 -------------
 1 file changed, 13 deletions(-)
 delete mode 100644 benchmark.py

diff --git a/benchmark.py b/benchmark.py
deleted file mode 100644
index cd405e64..00000000
--- a/benchmark.py
+++ /dev/null
@@ -1,13 +0,0 @@
-import timeit
-from appium.webdriver.webdriver import WebDriver
-
-setup = "from appium.webdriver.webdriver import WebDriver; mro = WebDriver.__mro__"
-filter_code = "list(filter(lambda x: not issubclass(x, WebDriver), mro))"
-gen_code = "list((x for x in mro if not issubclass(x, WebDriver)))"
-
-t1 = timeit.timeit(filter_code, setup=setup, number=100000)
-t2 = timeit.timeit(gen_code, setup=setup, number=100000)
-
-print(f"Filter + lambda: {t1:.5f}s")
-print(f"Generator expr: {t2:.5f}s")
-print(f"Improvement: {(t1-t2)/t1*100:.2f}%")

From 8feb64412c81d76813eef2b9c9665bea7a93d6f3 Mon Sep 17 00:00:00 2001
From: Dor-bl <59066376+Dor-bl@users.noreply.github.com>
Date: Mon, 10 Aug 2026 07:20:06 +0000
Subject: [PATCH 3/3] fix: pin appium-flutter-server download URL to v0.0.33 to
 fix CI

The previous config was pointing to `latest`, which resolved to the new `0.0.34` release. This `0.0.34` release is currently missing the `app-debug.apk` and `ios.zip` assets, leading to 404 errors during functional tests in CI. This commit pins it to the known working version `0.0.33`.
---
 .github/workflows/functional-test.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/functional-test.yml b/.github/workflows/functional-test.yml
index fecd4b1b..c4d81cd1 100644
--- a/.github/workflows/functional-test.yml
+++ b/.github/workflows/functional-test.yml
@@ -245,8 +245,8 @@ jobs:
       XCODE_VERSION: 16.4
       IOS_VERSION: 18.5
       IPHONE_MODEL: iPhone 16
-      FLUTTER_ANDROID_APP: "https://github.com/AppiumTestDistribution/appium-flutter-server/releases/latest/download/app-debug.apk"
-      FLUTTER_IOS_APP: "https://github.com/AppiumTestDistribution/appium-flutter-server/releases/latest/download/ios.zip"
+      FLUTTER_ANDROID_APP: "https://github.com/AppiumTestDistribution/appium-flutter-server/releases/download/0.0.33/app-debug.apk"
+      FLUTTER_IOS_APP: "https://github.com/AppiumTestDistribution/appium-flutter-server/releases/download/0.0.33/ios.zip"
       PREBUILT_WDA_PATH: ${{ github.workspace }}/wda/WebDriverAgentRunner-Runner.app
 
     steps: