Skip to content

API Rewrite #12

Description

@CallMeMSL

The current API has 2 major problems:

  • It doesn't follow ML code style conventions
  • It only implements just enough of the C FFI, got get a proof-of-concept fit-predict pipeline working
  • There is no idiomatic way to handle optional parameters or multiple validation sets.

The Code in booster.rs and dataset.rs should be rewritten to improve these points. Additionally, functionality extension should be easier, especially wrt. currently open Issues (#8, #6, #5, #3).

Guidelines to follow:

  • Use builder pattern for Booster and Dataset
  • Change function name to fit more in line with popular ML Frameworks like sk-learn

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions