Skip to content

Warnings logged when retrieving conversion split history #157

Description

@rnunn-bound

When retrieving the split history for a trade, the following warning is logged by the RestMethodMetadata class in ResCU:

GET request declared as consuming method body as application/x-www-form-urlencoded. While body is allowed, it should be ignored by the server. Is this intended? Method: public abstract com.currencycloud.client.model.ConversionSplitHistory com.currencycloud.client.CurrencyCloud.historySplitConversion(java.lang.String,java.lang.String,java.lang.String) throws com.currencycloud.client.model.ResponseException

It's clearly a harmless message, but does cause unwanted noise in our logs. We could obviously disable that logger, but would prefer to see this resolved within the SDK. Just removing the @Consumes(MediaType.APPLICATION_FORM_URLENCODED) annotation from the CurrencyCloud.historySplitConversion method should do the trick.

Note that there are a handful of other GET methods defined in the CurrencyCloud with the same annotation, and so they will also log the warning.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions