Source: docs/reviews/audio-graph-wave-b-review.md WB3b MEDIUM
Current: Hardcoded `Duration::from_secs(5)` in writer shutdown timeout.
Concern: "Chosen empirically" — not validated with real-world data. Could be:
- Too short: healthy fsync on a large transcript (10+ MB) + slow disk (HDD / network filesystem) might legitimately exceed 5s, causing the hard HIGH double-drop path.
- Too long: a wedged disk (NFS stall, drive died) causes `new_session_cmd` to block the UI for 5s which is user-visible jank.
Action:
- Add instrumentation (log fsync duration histogram at INFO level)
- Collect 1-2 weeks of real usage data
- Tune timeout to p99 of healthy flushes + safety margin
- Document the chosen value in a `// Chosen because...` comment citing the data
Effort: 1h initial instrumentation + 2 weeks wait + 30min tune.
Source: docs/reviews/audio-graph-wave-b-review.md WB3b MEDIUM
Current: Hardcoded `Duration::from_secs(5)` in writer shutdown timeout.
Concern: "Chosen empirically" — not validated with real-world data. Could be:
Action:
Effort: 1h initial instrumentation + 2 weeks wait + 30min tune.