Skip to content

[Frontend][Inbox] activeColumnId / activeColumnName in useInboxOrchestrator have no producer after PR #2580 (from its review) #2589

Description

@Chris0Jeky

Non-blocking residual from the fresh-context review of PR #2580 (#1984 finding 2, Paper Inbox scope truth), tracked here rather than fix-cycled. File references are at that PR's round-1 head bb35651fa.

LOW, dead code with a misleading shape. After PR #2580 the board's + capture control pushes { boardId } only, and nothing else in the app writes columnId into the Inbox route. useInboxOrchestrator.ts still exposes activeColumnId (~51) and activeColumnName (~59-64, resolves the column's display name off scopedBoard) and returns them (~629, ~633), but a repo-wide grep finds no production consumer: only the orchestrator itself, its spec, and the PaperInboxView.spec.ts stub object. clearScope's delete query.columnId (~522) still does real work for a hand-written URL and should stay.

A future reader of activeColumnName will reasonably assume a producer-consumer pair exists. Either remove the pair and its spec coverage (if the product ruling on #1984's real column contract is "no"), or leave it and add a comment stating it is retained for a hand-written URL only until that ruling lands. Do not resolve this before the #1984 ruling; the ruling decides which.

Refs #1984, PR #2580.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    frontendPrimary implementation impact in Vue/TypeScript UI and client runtime.tech-debtDebt cleanup or deferred engineering quality work with limited product-surface change.

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions