Skip to content

[Frontend][Review] Keep post-revision truth refresh retryable on failed or stalled reads #2460

Description

@Chris0Jeky

Context

PR #2448 adds a post-revision truth barrier before Approve or Apply. Independent review found two related failure-path gaps below the merge-blocking bar. Refs #2215 and PR #2448.

Current behavior

  • The explicit proposal-list read and six core selector reads have no caller-owned deadline. A transport that never settles can leave the decision rail locked with no retry path.
  • The selector batch uses Promise.allSettled and reports settled even when core evidence calls fail. The first action can therefore clear the post-save barrier while the Review surface shows empty fallback evidence.
  • No hidden mutation occurs. The first action is still consumed, and backend approval gates remain authoritative.

Acceptance

  • Bound the explicit post-revision proposal and selector reads with one caller-owned cancellation/deadline contract.
  • Distinguish a fully landed exact-key selector batch from failed, timed-out, aborted, or superseded outcomes.
  • On any non-landed outcome, retain the per-proposal barrier, unlock the rail, show truthful retry guidance, and ignore late completions.
  • Clear the barrier only after the exact proposal DTO and all required core evidence reads land for the same identity, status, expiry, defer state, and effective revision.
  • Prove stalled transport, partial and total selector failure, retry success, late-response suppression, and no approve or execute request before the successful second explicit action.

Out of scope

Do not redesign ordinary background selector degradation outside the post-revision decision barrier.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Priority IIIValuable but unscheduled: residuals, tech-debt, performance, depth work.bugSomething isn't workingfrontendPrimary implementation impact in Vue/TypeScript UI and client runtime.uxDiscoverability, accessibility, interaction model, and user workflow quality.

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions