-
Notifications
You must be signed in to change notification settings - Fork 0
[Frontend] Version-truth residuals from PR #1956: telemetry appVersion literal (already wrong), duplicated root derivation, demo-build stamp decision #1962
Copy link
Copy link
Open
Labels
Priority IIIValuable but unscheduled: residuals, tech-debt, performance, depth work.Valuable but unscheduled: residuals, tech-debt, performance, depth work.docsImprovements or additions to documentationImprovements or additions to documentationdogfoodingFrom real personal/beta use; evidence-grade product feedback (exempt from intake severity bar).From real personal/beta use; evidence-grade product feedback (exempt from intake severity bar).frontendPrimary implementation impact in Vue/TypeScript UI and client runtime.Primary implementation impact in Vue/TypeScript UI and client runtime.product-truthProduct or docs claim something unsupported, misleading, or silently untrue; truth-repair work.Product or docs claim something unsupported, misleading, or silently untrue; truth-repair work.tech-debtDebt cleanup or deferred engineering quality work with limited product-surface change.Debt cleanup or deferred engineering quality work with limited product-surface change.
Description
Activity
Metadata
Metadata
Assignees
Labels
Priority IIIValuable but unscheduled: residuals, tech-debt, performance, depth work.Valuable but unscheduled: residuals, tech-debt, performance, depth work.docsImprovements or additions to documentationImprovements or additions to documentationdogfoodingFrom real personal/beta use; evidence-grade product feedback (exempt from intake severity bar).From real personal/beta use; evidence-grade product feedback (exempt from intake severity bar).frontendPrimary implementation impact in Vue/TypeScript UI and client runtime.Primary implementation impact in Vue/TypeScript UI and client runtime.product-truthProduct or docs claim something unsupported, misleading, or silently untrue; truth-repair work.Product or docs claim something unsupported, misleading, or silently untrue; truth-repair work.tech-debtDebt cleanup or deferred engineering quality work with limited product-surface change.Debt cleanup or deferred engineering quality work with limited product-surface change.
Projects
- StatusShow more project fieldsPending
1.
telemetryStore.appVersionis a hand-maintained literal and already wrongfrontend/taskdeck-web/src/store/telemetryStore.ts:158shipsappVersion: '0.1.0'("Will be set from build config in future") on every telemetry event (api/telemetryApi.ts:32, pinned by two specs). The shipped release is v0.1.1 — the exact misattribution failure mode #1948 was about, on a reporting surface. Fix: source it fromuseProductVersion(or the same/health/livetruth), with a null-safe fallback that omits the field rather than lying.2. Server-root derivation is duplicated
api/versionApi.tsresolveApiRoot()copies the regex fromcomposables/useBoardRealtime.ts:22-26verbatim. Extract a sharedutils/apiRoot.tsconsumed by both so the two cannot drift (the #1956 fix round adds a pureapiRootFrom()+ table test — move it there and point the hub at it).3. Demo build renders no version at all (recorded trade-off)
The Pages demo builds with
VITE_API_BASE_URL: ''→ demo-mode short-circuit → empty footer. Internally consistent ("no version beats a wrong version") but the public demo is where beta testers file reports. If wanted: a build-time Vitedefinestamped from the tag is not a hand-maintained literal and would cover the demo. Decision, not a defect.Acceptance criteria
Refs: #1948, PR #1956 review thread, tracker #1947.