diff --git a/projects/packages/premium-analytics/changelog/fix-pa-dialog-focus-ring-clipping b/projects/packages/premium-analytics/changelog/fix-pa-dialog-focus-ring-clipping new file mode 100644 index 000000000000..505cdd9ef03f --- /dev/null +++ b/projects/packages/premium-analytics/changelog/fix-pa-dialog-focus-ring-clipping @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Dialogs: keep the comment field's focus ring from being clipped by the dialog footer. diff --git a/projects/packages/premium-analytics/routes/dashboard/components/feedback/feedback-modal.module.scss b/projects/packages/premium-analytics/routes/dashboard/components/feedback/feedback-modal.module.scss deleted file mode 100644 index 9ff658789074..000000000000 --- a/projects/packages/premium-analytics/routes/dashboard/components/feedback/feedback-modal.module.scss +++ /dev/null @@ -1,6 +0,0 @@ -// TODO: drop when @wordpress/ui fixes this upstream. `Dialog.Content` loses its -// bottom padding under a `Dialog.Footer` and also scrolls, clipping the last -// field's focus outline; this gives back the outline's offset plus its width. -.body { - padding-block-end: calc(var(--wpds-border-width-focus) * 2); -} diff --git a/projects/packages/premium-analytics/routes/dashboard/components/feedback/feedback-modal.tsx b/projects/packages/premium-analytics/routes/dashboard/components/feedback/feedback-modal.tsx index e2c14a482bad..f10b182b6048 100644 --- a/projects/packages/premium-analytics/routes/dashboard/components/feedback/feedback-modal.tsx +++ b/projects/packages/premium-analytics/routes/dashboard/components/feedback/feedback-modal.tsx @@ -10,7 +10,6 @@ import { __ } from '@wordpress/i18n'; */ import { useTrackEvent } from '../../hooks/use-track-event'; import { FeedbackFields } from './feedback-fields'; -import styles from './feedback-modal.module.scss'; // Reaches Happiness as the subject line of the feedback email ("Feedback received // from …"), so it has to name the surface without any further context. @@ -101,7 +100,7 @@ export function FeedbackModal( { onClose }: FeedbackModalProps ) { ) : ( <> - +