From 59a7f493e3e61e8dbb13cb044d032216120a4272 Mon Sep 17 00:00:00 2001 From: joachimckh Date: Fri, 17 Jul 2026 12:22:53 +0200 Subject: [PATCH 1/5] pvalue check on rho(phi) --- PWGJE/Tasks/jetSpectraEseTask.cxx | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/PWGJE/Tasks/jetSpectraEseTask.cxx b/PWGJE/Tasks/jetSpectraEseTask.cxx index e7ad69403dd..c06d8fd8100 100644 --- a/PWGJE/Tasks/jetSpectraEseTask.cxx +++ b/PWGJE/Tasks/jetSpectraEseTask.cxx @@ -111,6 +111,7 @@ struct JetSpectraEseTask { Configurable> cfgOccupancyPtCut{"cfgOccupancyPtCut", {0, 100}, "pT cut"}; Configurable cfgrhoPhi{"cfgrhoPhi", true, "Flag for rho(phi)"}; + Configurable cfgRhoPhiPvalCriteria{"cfgRhoPhiPvalCriteria", true, "Use instead of rho(phi) when the rho(phi) fit p-value is below 0.01"}; Configurable cfgnTotalSystem{"cfgnTotalSystem", 7, "total qvector number // look in Qvector table for this number"}; Configurable cfgnCorrLevel{"cfgnCorrLevel", 3, "QVector step: 0 = no corr, 1 = rect, 2 = twist, 3 = full"}; @@ -345,6 +346,7 @@ struct JetSpectraEseTask { registry.add("eventQA/before/hVtxZ", ";z_{vtx} (cm);entries", {HistType::kTH1F, {{vertexZAxis}}}); registry.add("eventQA/after/hVtxZ", ";z_{vtx} (cm);entries", {HistType::kTH1F, {{vertexZAxis}}}); + registry.add("eventQA/hRhoPhiCheck", "event status;event status;entries", {HistType::kTH1F, {{2, 0.0, 2.0}}}); registry.get(HIST("eventQA/hEventCounter"))->GetXaxis()->SetBinLabel(kFilteredInputEv, "Input filtered event"); registry.get(HIST("eventQA/hEventCounter"))->GetXaxis()->SetBinLabel(kEventSel, "Event selection"); @@ -1478,6 +1480,14 @@ struct JetSpectraEseTask { return nullptr; auto cDF = 1. - TMath::Gamma(nDF, chi2); + if constexpr (fillHist) + registry.fill(HIST("eventQA/hRhoPhiCheck"), 0.5); + if (cfgRhoPhiPvalCriteria && cDF < 0.01) { + modulationFit->SetParameter(1, 0.); + modulationFit->SetParameter(3, 0.); + if constexpr (fillHist) + registry.fill(HIST("eventQA/hRhoPhiCheck"), 1.5); + } if constexpr (fillHist) { registry.fill(HIST("eventQA/hPValueCentCDF"), col.centFT0M(), cDF); From a9da120ea5e3d7b9f2f3bb5cdeda1effa6157f19 Mon Sep 17 00:00:00 2001 From: joachimckh Date: Fri, 17 Jul 2026 12:28:07 +0200 Subject: [PATCH 2/5] linter --- PWGJE/Tasks/jetSpectraEseTask.cxx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PWGJE/Tasks/jetSpectraEseTask.cxx b/PWGJE/Tasks/jetSpectraEseTask.cxx index c06d8fd8100..cee6e4cac69 100644 --- a/PWGJE/Tasks/jetSpectraEseTask.cxx +++ b/PWGJE/Tasks/jetSpectraEseTask.cxx @@ -1483,8 +1483,9 @@ struct JetSpectraEseTask { if constexpr (fillHist) registry.fill(HIST("eventQA/hRhoPhiCheck"), 0.5); if (cfgRhoPhiPvalCriteria && cDF < 0.01) { - modulationFit->SetParameter(1, 0.); - modulationFit->SetParameter(3, 0.); + const float noBkg= 0.0f; + modulationFit->SetParameter(1, noBkg); + modulationFit->SetParameter(3, noBkg); if constexpr (fillHist) registry.fill(HIST("eventQA/hRhoPhiCheck"), 1.5); } From e5c4d56461cd6c53703c6e6b3a5e36ef97b0f5cc Mon Sep 17 00:00:00 2001 From: joachimckh Date: Fri, 17 Jul 2026 12:44:36 +0200 Subject: [PATCH 3/5] fix cpp issues --- PWGJE/Tasks/jetSpectraEseTask.cxx | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/PWGJE/Tasks/jetSpectraEseTask.cxx b/PWGJE/Tasks/jetSpectraEseTask.cxx index cee6e4cac69..0c5d8f9b567 100644 --- a/PWGJE/Tasks/jetSpectraEseTask.cxx +++ b/PWGJE/Tasks/jetSpectraEseTask.cxx @@ -607,7 +607,7 @@ struct JetSpectraEseTask { if (cfg.hEff == nullptr) { LOGF(fatal, "Could not find %s as TH1F in track efficiency list %s", efficiencyName.c_str(), cfgEfficiency.value.c_str()); } - LOGF(info, "Loaded tracking efficiency %s from %s (%p)", efficiencyName.c_str(), cfgEfficiency.value.c_str(), (void*)cfg.hEff); + LOGF(info, "Loaded tracking efficiency %s from %s (%p)", efficiencyName.c_str(), cfgEfficiency.value.c_str(), static_cast(cfg.hEff)); } if (!cfgEfficiency3D.value.empty()) { cfg.h3EffList = ccdb->getForTimeStamp(cfgEfficiency3D, timestamp); @@ -618,7 +618,7 @@ struct JetSpectraEseTask { if (cfg.h3Eff == nullptr) { LOGF(fatal, "Could not find %s as TH3F in 3D track efficiency list %s", efficiencyName.c_str(), cfgEfficiency3D.value.c_str()); } - LOGF(info, "Loaded 3D tracking efficiency %s from %s (%p)", efficiencyName.c_str(), cfgEfficiency3D.value.c_str(), (void*)cfg.h3Eff); + LOGF(info, "Loaded 3D tracking efficiency %s from %s (%p)", efficiencyName.c_str(), cfgEfficiency3D.value.c_str(), static_cast(cfg.h3Eff)); cfg.is3D = true; } cfg.isLoaded = true; @@ -1483,9 +1483,9 @@ struct JetSpectraEseTask { if constexpr (fillHist) registry.fill(HIST("eventQA/hRhoPhiCheck"), 0.5); if (cfgRhoPhiPvalCriteria && cDF < 0.01) { - const float noBkg= 0.0f; - modulationFit->SetParameter(1, noBkg); - modulationFit->SetParameter(3, noBkg); + const float noFlow = 0.0f; + modulationFit->SetParameter(1, noFlow); + modulationFit->SetParameter(3, noFlow); if constexpr (fillHist) registry.fill(HIST("eventQA/hRhoPhiCheck"), 1.5); } From da0a2b804327c817820948a3d39094ebba7e8ab5 Mon Sep 17 00:00:00 2001 From: joachimckh Date: Fri, 17 Jul 2026 12:54:43 +0200 Subject: [PATCH 4/5] linter --- PWGJE/Tasks/jetSpectraEseTask.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PWGJE/Tasks/jetSpectraEseTask.cxx b/PWGJE/Tasks/jetSpectraEseTask.cxx index 0c5d8f9b567..49f2bf77da9 100644 --- a/PWGJE/Tasks/jetSpectraEseTask.cxx +++ b/PWGJE/Tasks/jetSpectraEseTask.cxx @@ -1484,8 +1484,8 @@ struct JetSpectraEseTask { registry.fill(HIST("eventQA/hRhoPhiCheck"), 0.5); if (cfgRhoPhiPvalCriteria && cDF < 0.01) { const float noFlow = 0.0f; - modulationFit->SetParameter(1, noFlow); - modulationFit->SetParameter(3, noFlow); + modulationFit->SetParameter(1, noFlow); // o2-linter: disable=magic-number + modulationFit->SetParameter(3, noFlow); // o2-linter: disable=magic-number if constexpr (fillHist) registry.fill(HIST("eventQA/hRhoPhiCheck"), 1.5); } From 05ebb3ee583fd8765d26fcb028afae934d6febf9 Mon Sep 17 00:00:00 2001 From: joachimckh Date: Fri, 17 Jul 2026 12:58:00 +0200 Subject: [PATCH 5/5] clang/linter --- PWGJE/Tasks/jetSpectraEseTask.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PWGJE/Tasks/jetSpectraEseTask.cxx b/PWGJE/Tasks/jetSpectraEseTask.cxx index 49f2bf77da9..d00884199fd 100644 --- a/PWGJE/Tasks/jetSpectraEseTask.cxx +++ b/PWGJE/Tasks/jetSpectraEseTask.cxx @@ -1484,8 +1484,8 @@ struct JetSpectraEseTask { registry.fill(HIST("eventQA/hRhoPhiCheck"), 0.5); if (cfgRhoPhiPvalCriteria && cDF < 0.01) { const float noFlow = 0.0f; - modulationFit->SetParameter(1, noFlow); // o2-linter: disable=magic-number - modulationFit->SetParameter(3, noFlow); // o2-linter: disable=magic-number + modulationFit->SetParameter(1, noFlow); // o2-linter: disable=magic-number (fit params) + modulationFit->SetParameter(3, noFlow); // o2-linter: disable=magic-number (fit params) if constexpr (fillHist) registry.fill(HIST("eventQA/hRhoPhiCheck"), 1.5); }