Skip to content

Part count not updated when toggling individual checkboxes #4

Description

@dirlligafu

Description:

The "X of Y shown, Z included" counter in the Parts section does not update when individual part checkboxes are toggled. It only updates when using the "Select All" or "Deselect All" buttons.

Steps to reproduce:

  1. Load any model file
  2. Note the counter - e.g. "35 of 35 shown, 35 included"
  3. Uncheck one or more individual parts
  4. Counter still shows "35 included"
  5. Click "Deselect All" - counter correctly drops to "0 included"

Expected behavior:

The counter updates immediately whenever any checkbox is toggled, reflecting the current number of included parts.

Root cause:

The change event listener on individual checkboxes updates excludedParts but does not refresh the counter display. The counter is only recalculated inside renderPartList(), which is called by selectAll() but not on individual checkbox changes.

Fix:

A pull request with a fix is available: extracts the counter update into a dedicated updatePartCount() function and calls it from both renderPartList() and the individual checkbox change listener.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions