[FR] Improve error message for invalid feeds when importing OPML file

[aportela]

Problem

I have a opml file exported from another rss reader software. Has a lot of feeds and seems that there are some old entries that not exist. When import on fusion, i see a error message "invalid link" but I don't know what link is failing (for removing with an editor from opml file).

Additionally, since an error occurs, none of the feeds from the OPML file are imported in the end. I assume everything is wrapped in a transaction and is rolled back when errors occur.

Proposed Solution

Show on error message the failed link as example (feed.go file)

if err := httpc.ValidateRequestURL(c.Request.Context(), *req.Link, h.config.AllowPrivateFeeds); err != nil {
badRequestError(c, "invalid rss link: "+*req.Link)
return
}

Alternatives Considered

It would be better if, when importing the OPML file, the process skipped a feed if an error occurs and continued with the next one, so that the feeds that are imported successfully are still added.

[aportela]

For the alternative suggestion (continue importing if a feed has errors) I have a suggestion:

When I re-import same opml without errors I see a warning/error message "233 feeds failed: duplicate feed", maybe will be a good idea not returning error and storing/appending the validateRequestURL error result on result.Errors ?

I'm refering to the end of feed.go file , on this code block

dataResponse(c, gin.H{
		"created": result.Created,
		"failed":  len(result.Errors),
		"errors":  result.Errors,
	})